This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5682/

On October 23rd, 2010, 3:40 p.m., Wolfgang = Rohdewald wrote:

For testi=
ng you can simply make sure that any two tiles match. Then any game is alwa=
y winnable.
Here comes the patch (untested):

--- x.cpp       2010-10-23 17:33:00.586617000 +0200
+++ GameData.cpp        2010-10-23 17:33:16.656617001 +0200
@@ -678,13 +678,7 @@
     // don't compare 'equal' positions
     if( memcmp( &Pos1, &Pos2, sizeof(POSITION) ) )
     {
-        UCHAR FA =3D Pos1.f;
-        UCHAR FB =3D Pos2.f;
-
-        if( (FA =3D=3D FB)
-         || ( isFlower( FA ) && isFlower( FB ) )
-         || ( isSeason( FA ) && isSeason( FB ) ) )
-            return( true );
+       return( true );
     }
     return( false );
 }

The patch l=
ooks correct. It would be nice however if you could win a game to verify it=
 :) I am sending an easy.layout to the kdegames list, so you could win quic=
kly and test it. Then, ship it.

- Mauricio

On October 23rd, 2010, 12:50 p.m., Antonis Tsiapaliokas wrote:

Review request for KDE Games.

By Antonis Tsiapaliokas.

Updated 2010-10-23 12:50:22

Descripti= on

Hello

This is my first effort to help the kdegames,so i am sorry if i have done s=
omething wrong...This bug regards the kmahjongg game.This patch is fixing t=
he bug 215352.All the information that you will need, are located into the =
bug report... With a few words, after someone wins, the undo button is stil=
l enable and full functional...

Testing <= /h1>

The kmahjongg game compiles and runs fine.But there is a pro=
blem,which it will sound to you very silly... I have create the patch but i=
 cannot win the game so i cannot test my patch... But i have found another =
way to test my patch, and there works fine... If you look at the kmahjongg.=
cpp (it is located into the kdegames/kmahjongg) at the lines 174("undo=
Action =3D KStandardGameAction::undo(this, SLOT(undo()), actionCollection()=
);") and 119-120 (connect( bw, SIGNAL( gameOver(unsigned short , unsig=
ned short)), this,SLOT( gameOver(unsigned short , unsigned short)));) those=
 two functions are connected with the bw object.So if i add the code from m=
y patch into the KMahjongg::undo() method and after i make 10 moves into th=
e game, i will be able to undo only the last one because when i hit the und=
o button then, the code from my patch is called and the undo button is beco=
ming dissable (from enable). So instead of adding the code into the KMahjon=
gg::undo(), if i add it, into the KMahjongg::gameOver() then it should work=
 fine... I know that this is very wrong, as regards the testing for my patc=
h but i could not find something better...

Bugs: 215352

Diffs=

trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp (1188798)

View Diff