[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request: Port all KNewStuff2 code in
From:       "Dmitry Suzdalev" <dimsuz () gmail ! com>
Date:       2010-03-22 10:26:15
Message-ID: 20100322102615.19562.43757 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3343/#review4609
-----------------------------------------------------------



trunk/KDE/kdegames/katomic/chooselevelsetdialog.h
<http://reviewboard.kde.org/r/3343/#comment4112>

    I'd suggest to not introduce workarounds where we can fix it in the right place \
(=KNS3 headers).  
    Of course if it's not an option to change that in kdelibs, this needs to be done \
here.  
    Frederik?..


- Dmitry


On 2010-03-21 21:28:11, Parker Coates wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3343/
> -----------------------------------------------------------
> 
> (Updated 2010-03-21 21:28:11)
> 
> 
> Review request for KDE Games and Frederik Gladhorn.
> 
> 
> Summary
> -------
> 
> I just went through KDEGames trunk and updated all uses of KNewStuff2 to \
> KNewStuff3. Most applications use KGameThemeSelector, so only their knsrc files \
> needed updating. 
> Summary of changes:
> 
> KAtomic: Updated custom level set dialog. Had to work around a bug in the KNS3 \
> interface. 
> KBlocks: Uses KGameThemeSelector. Updated knsrc file.
> 
> KDiamond: Uses KGameThemeSelector. Updated knsrc file.
> 
> KGoldrunner: Has a knsrc file, but doesn't seem to use it anywhere. Updated it \
> anyway. 
> Kigo: Has two knsrc files: one for saved games, one for themes. Unfortunately, both \
> of them use the same provider URL, so the Get More Themes button in the theme \
> selector lets you download saved games to the themes directory, which is obviously \
> quite confusing. So I disable the button in the theme selector until that is sorted \
> out. 
> KMines: Has an invalid, unused knsrc file. Updated it anyway.
> 
> KTron: Uses KGameThemeSelector. Updated knsrc file. (There doesn't seem to be \
> anything on the server for it, though.) 
> KGameThemeSelector: Updated to KNewStuff3.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdegames/katomic/chooselevelsetdialog.h 1106088 
> trunk/KDE/kdegames/katomic/chooselevelsetdialog.cpp 1106088 
> trunk/KDE/kdegames/katomic/katomic.knsrc 1106088 
> trunk/KDE/kdegames/katomic/levelsetwidget.ui 1106088 
> trunk/KDE/kdegames/kblocks/kblocks.knsrc 1106088 
> trunk/KDE/kdegames/kdiamond/src/kdiamond.knsrc 1106088 
> trunk/KDE/kdegames/kgoldrunner/themes/kgoldrunner.knsrc 1106088 
> trunk/KDE/kdegames/kigo/src/gui/mainwindow.cpp 1106088 
> trunk/KDE/kdegames/kmines/kmines.knsrc 1106088 
> trunk/KDE/kdegames/ktron/ktron.knsrc 1106088 
> trunk/KDE/kdegames/libkdegames/CMakeLists.txt 1106088 
> trunk/KDE/kdegames/libkdegames/kgamethemeselector.cpp 1106088 
> 
> Diff: http://reviewboard.kde.org/r/3343/diff
> 
> 
> Testing
> -------
> 
> Installed and uninstalled a theme for all those games that support it.
> 
> 
> Thanks,
> 
> Parker
> 
> 

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel


[prev in list] [next in list] [prev in thread] [next in thread]