[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request: Some wishes and fixes for
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2010-02-27 2:14:41
Message-ID: 20100227021441.23804.60049 () localhost
[Download RAW message or body]



> On 2010-02-27 02:12:33, Matthew Woehlke wrote:
> > /trunk/KDE/kdegames/kbounce/backgroundselector.cpp, line 94
> > <http://reviewboard.kde.org/r/3061/diff/1/?file=19978#file19978line94>
> > 
> > Qt::Red? I didn't try this, but reading the code, this looks like it is setting \
> > the color to display an error message, which should never, ever use a hard-coded \
> > color. 
> > Use KColorScheme instead.

Sorry, I did that wrong; was meant to be a reply to Dmitry's comment on this same \
line. But anyway... hard-coded colors are evil :-).


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3061/#review4300
-----------------------------------------------------------


On 2010-02-26 16:10:29, Andreas Scherf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3061/
> -----------------------------------------------------------
> 
> (Updated 2010-02-26 16:10:29)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Added random background changing to kbounce. Wish: 221717
> And i fixed one issue of BUG:228063 were resizing did not pause the collision \
> detection. And initial work for wish: 219507    	
> 
> 
> This addresses bugs 219507, 221717 and 228063.
> https://bugs.kde.org/show_bug.cgi?id=219507
> https://bugs.kde.org/show_bug.cgi?id=221717
> https://bugs.kde.org/show_bug.cgi?id=228063
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdegames/kbounce/CMakeLists.txt 1096082 
> /trunk/KDE/kdegames/kbounce/backgroundselector.h PRE-CREATION 
> /trunk/KDE/kdegames/kbounce/backgroundselector.cpp PRE-CREATION 
> /trunk/KDE/kdegames/kbounce/backgroundselector.ui PRE-CREATION 
> /trunk/KDE/kdegames/kbounce/ball.cpp 1096082 
> /trunk/KDE/kdegames/kbounce/board.h 1096082 
> /trunk/KDE/kdegames/kbounce/board.cpp 1096082 
> /trunk/KDE/kdegames/kbounce/gamewidget.h 1096082 
> /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1096082 
> /trunk/KDE/kdegames/kbounce/kbounce.kcfg 1096082 
> /trunk/KDE/kdegames/kbounce/mainwindow.h 1096082 
> /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1096082 
> /trunk/KDE/kdegames/kbounce/renderer.h 1096082 
> /trunk/KDE/kdegames/kbounce/renderer.cpp 1096082 
> /trunk/KDE/kdegames/kbounce/wall.cpp 1096082 
> 
> Diff: http://reviewboard.kde.org/r/3061/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.kde.org/r/3061/s/322/
> 
> http://reviewboard.kde.org/r/3061/s/323/
> 
> 
> Thanks,
> 
> Andreas
> 
> 

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel


[prev in list] [next in list] [prev in thread] [next in thread]