From kde-games-devel  Wed Jun 03 20:33:23 2009
From: "Albert Astals Cid" <aacid () kde ! org>
Date: Wed, 03 Jun 2009 20:33:23 +0000
To: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: Threaded card rendering in
Message-Id: <20090603203323.22003.2862 () localhost>
X-MARC-Message: https://marc.info/?l=kde-games-devel&m=124406124313051


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/792/#review1267
-----------------------------------------------------------


Downloaded, compiled, played with it, did not crash.
If you have tested it and it gives a noticeable speedup i'd go with the ship it and sell it as a bugfix ;-)

- Albert


On 2009-06-02 18:23:51, Parker Coates wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/792/
> -----------------------------------------------------------
> 
> (Updated 2009-06-02 18:23:51)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> As describe here (http://reviewboard.kde.org/r/676/), some optimisations have been made to KCardCache to allow the loading of SVG files and rendering of card graphics in the background. KPat has already been modified to take advantage of this functionality, but LSkat has not.
> 
> This patch attempts to add threaded loading to LSkat. The implementation isn't the most elegant, but it is relatively simple. This is my first time looking at the LSkat code, so feedback is definitely appreciated.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/lskat/src/thememanager.h 973384 
>   trunk/KDE/kdegames/lskat/src/thememanager.cpp 973384 
> 
> Diff: http://reviewboard.kde.org/r/792/diff
> 
> 
> Testing
> -------
> 
> I've changed decks and changed the window size a few dozen times. I've also played through a few games. Thus far I've notice no ill effects.
> 
> 
> Thanks,
> 
> Parker
> 
>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel