[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] KScoreDialog
From:       Matt Williams <matt () milliams ! com>
Date:       2008-04-28 17:47:45
Message-ID: 200804281848.00449.matt () milliams ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Monday 28 April 2008 18:16:41 Fela Winkelmolen wrote:
> On Monday 28 April 2008, Matt Williams wrote:
> > On Monday 28 April 2008 15:40:37 Fela Winkelmolen wrote:
> > > 7. Clicking on close while entering the user name discarts what is
> > > written so far.. maybe there could be two buttons: Ok and Cancel.
> >
> > There's a bug report on this and I agree, I plan to add an 'Ok' button.
>
> Only one button but also registering the name may also be an idea.. I mean,
> why would one not want to register his highscore?? In the worst case one
> can always leave the name empty...

It turns out the code had some sort of functionality for this but it wasn't 
being used. Fela, could you see if the attached patch fixes this at all. It 
seems to work for me.

Regards,
Matt Williams

["correctbuttons.patch" (text/x-diff)]

Index: libkdegames/highscore/kscoredialog.cpp
===================================================================
--- libkdegames/highscore/kscoredialog.cpp	(revision 802148)
+++ libkdegames/highscore/kscoredialog.cpp	(working copy)
@@ -465,6 +465,9 @@
             {
                 d->player=score[Name];
                 d->newName = QPair<QString,int>(d->configGroup,i+1);
+                
+                setButtons(Ok|Cancel);
+                connect(this, SIGNAL(okClicked()), SLOT(slotGotName()));
             }
             else
                 d->saveScores();

["signature.asc" (application/pgp-signature)]

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel


[prev in list] [next in list] [prev in thread] [next in thread]