[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] bug ? in libkdegames
From:       "Paolo Capriotti" <p.capriotti () gmail ! com>
Date:       2007-05-17 8:42:01
Message-ID: 87b37d60705170142j10afec55m7fe221b4a76967a5 () mail ! gmail ! com
[Download RAW message or body]

On 5/16/07, Mauricio Piacentini <mauricio@tabuleiro.com> wrote:
> > to match KGameCanvasItem declaration, but changing that makes the
> > KGameCanvasGroup function not compile as it calls += over delta.
> >
> > Can you fix that?
>
> Fix committed, KBattleship and KGoldrunner are back to running state now.

Almost :) You forgot to update the references to delta in the function body:

Index: kgamecanvas.cpp
===================================================================
--- kgamecanvas.cpp     (revision 665571)
+++ kgamecanvas.cpp     (working copy)
@@ -575,11 +575,11 @@

   for(int i=0;i<m_items.size();i++) {
     KGameCanvasItem *el = m_items[i];
-    QRect r = el->rect().translated(delta);
+    QRect r = el->rect().translated(adelta);

     if( el->m_visible && prect.intersects( r ) && preg.contains( r ) ) {
       el->m_last_rect = r;
-      el->paintInternal(p,prect,preg,delta,cumulative_opacity);
+      el->paintInternal(p,prect,preg,adelta,cumulative_opacity);
     }
   }

Now it seems to work. I've analyzed the other EBN-related changes, and
they all seem to be safe (though they alter the coding convention used
for kgamecanvas... is this intentional?).

Paolo
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]