[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: KCGroups in KDEreview
From:       Jonathan Riddell <jr () jriddell ! org>
Date:       2023-07-04 12:46:06
Message-ID: CANX=XXM8y95ps7bG+AvrRTobwUrHkb3=SEK4PPa1YJ8noFxkYw () mail ! gmail ! com
[Download RAW message or body]

I opened an issue in line with the new kdereview process

https://invent.kde.org/libraries/kcgroups/-/issues/1

Jonathan


On Sat, 21 Nov 2020 at 00:38, Albert Astals Cid <aacid@kde.org> wrote:

> El divendres, 20 de novembre de 2020, a les 14:55:16 CET, Henri Chain va
> escriure:
> > Hello everyone,
> >
> > KCgroups has been moved to KDEReview !
> > What is that, you ask ? It's a library that wraps the systemd dbus API
> to
> > expose a higher-level concept of desktop application and allow control
> of its
> > system resource usage (CPU, RAM, IO, etc).
> >
> > It relies on the recent ability of plasma to launch applications in
> their own
> > systemd scopes, with correspond to cgroups and provides a more robust
> > definition for an application (more details at
> https://lwn.net/Articles/834329/
> > ) .
> >
> > The main use of the library is to expose related resource control
> settings for
> > those applications, at a user space level that other KDE applications
> and
> > frameworks can use, including consumption straight from QML as
> demonstrated in
> > the test application.
> >
> > KCgroups is intended to become a (Tier 1) framework. A first user of
> this
> > library might be the foreground window CPU booster daemon that is
> available
> > here:
> https://invent.kde.org/libraries/kcgroups/-/tree/work/foreground-booster
> >
> > Packages are already available for both Neon and Arch Linux.
> >
> > Looking forward to your feedback and ideas for using this,
>
> I'm a bit scared about your optional class being there all in the main
> namespace. I'd suggest putting in some "namespace kcgroups{}" or name it
> kcgoptional or something.
>
> you have a few properties without NOTIFY, ideally you should either add it
> if they can change or mark them as CONSTANT if they can't.
>
> Cheers,
>   Albert
>
>
> > Henri
> >
> >
> >
>
>
>
>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div>I opened an issue in line with the new kdereview \
process</div><div><br></div><div><a \
href="https://invent.kde.org/libraries/kcgroups/-/issues/1">https://invent.kde.org/lib \
raries/kcgroups/-/issues/1</a></div><div><br></div><div>Jonathan</div><div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 21 Nov 2020 at 00:38, \
Albert Astals Cid &lt;<a href="mailto:aacid@kde.org">aacid@kde.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">El divendres, 20 de \
novembre de 2020, a les 14:55:16 CET, Henri Chain va escriure:<br> &gt; Hello \
everyone,<br> &gt; <br>
&gt; KCgroups has been moved to KDEReview !<br>
&gt; What is that, you ask ? It&#39;s a library that wraps the systemd dbus API to \
<br> &gt; expose a higher-level concept of desktop application and allow control of \
its <br> &gt; system resource usage (CPU, RAM, IO, etc).<br>
&gt; <br>
&gt; It relies on the recent ability of plasma to launch applications in their own \
<br> &gt; systemd scopes, with correspond to cgroups and provides a more robust <br>
&gt; definition for an application (more details at <a \
href="https://lwn.net/Articles/834329/" rel="noreferrer" \
target="_blank">https://lwn.net/Articles/834329/</a> <br> &gt; ) .<br>
&gt; <br>
&gt; The main use of the library is to expose related resource control settings for \
<br> &gt; those applications, at a user space level that other KDE applications and \
<br> &gt; frameworks can use, including consumption straight from QML as demonstrated \
in <br> &gt; the test application.<br>
&gt; <br>
&gt; KCgroups is intended to become a (Tier 1) framework. A first user of this <br>
&gt; library might be the foreground window CPU booster daemon that is available <br>
&gt; here: <a href="https://invent.kde.org/libraries/kcgroups/-/tree/work/foreground-booster" \
rel="noreferrer" target="_blank">https://invent.kde.org/libraries/kcgroups/-/tree/work/foreground-booster</a><br>
 &gt; <br>
&gt; Packages are already available for both Neon and Arch Linux.<br>
&gt; <br>
&gt; Looking forward to your feedback and ideas for using this,<br>
<br>
I&#39;m a bit scared about your optional class being there all in the main namespace. \
I&#39;d suggest putting in some &quot;namespace kcgroups{}&quot; or name it \
kcgoptional or something.<br> <br>
you have a few properties without NOTIFY, ideally you should either add it if they \
can change or mark them as CONSTANT if they can&#39;t.<br> <br>
Cheers,<br>
   Albert<br>
<br>
<br>
&gt; Henri<br>
&gt; <br>
&gt; <br>
&gt; <br>
<br>
<br>
<br>
<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]