[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Recent breakage in kwallet
From:       Marco Martin <notmart () gmail ! com>
Date:       2020-05-26 7:31:26
Message-ID: CAD6_BosE-101eAgi3_4tmuN5xpBRA69X5t0Qtfne28oFiprFDg () mail ! gmail ! com
[Download RAW message or body]

would the recent patch
https://invent.kde.org/frameworks/kwallet/-/merge_requests/1
fix anything?

On Sat, May 16, 2020 at 10:40 AM David Faure <faure@kde.org> wrote:
>
> On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote:
> > Hi all,
> > Recently, the package of KWallet framework for neon (devel unstable,
> > package built out of current master state) seems to be broken: kwallet
> > now can't open anymore wallets previously created (it works if the
> > local kwallet data is deleted and recreated)
> > the weird thing is that it seems that with a manual build it works instead.
> > The only kinda suspicious commit is
> > 850219f83e7d746 fix compilation with -Werror=undef
> > which seems to fix.. big endian for everyone?
>
> It was supposed to only fix compiler warnings without changing behaviour at
> all.
>
> #if Q_BYTE_ORDER == Q_BIG_ENDIAN
> when neither is defined, evaluates to #if 0 == 0  (and warns)
>
> I defined both to 1, for the same result, but so that -Wundef doesn't warn.
>
> > still no idea why is broken only the distro-built package
>
> Any neon-specific patches to kwallet?
>
> --
> David Faure, faure@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]