[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D29369: Use UI marker context in more tr() calls
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2020-05-03 13:30:17
Message-ID: 49c301e66c268b4bb6d372aac9fcc2b2 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added inline comments.

INLINE COMMENTS

> kbookmarkmenu.cpp:288
>  
> -    QString title = tr("Open Folder in Tabs");
> +    const QString title = tr("Open Folder in Tabs", "@action:inmenu");
>  

@title:inmenu?

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D29369

To: kossebau, #frameworks, #localization
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

[Attachment #3 (text/html)]

<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D29369">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D29369#inline-168037">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kbookmarkmenu.cpp:288</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
class="n">QString</span> <span class="n">title</span> <span style="color: \
#aa2211">=</span> <span class="n">tr</span><span class="p">(</span><span \
style="color: #766510">&quot;Open Folder in Tabs&quot;</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: \
#aa4000"><span class="bright">const</span></span><span class="bright"> </span><span \
class="n">QString</span> <span class="n">title</span> <span style="color: \
#aa2211">=</span> <span class="n">tr</span><span class="p">(</span><span \
style="color: #766510">&quot;Open Folder in Tabs<span \
class="bright">&quot;</span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span style="color: \
#766510"><span class="bright">&quot;@action:inmenu</span>&quot;</span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;"><span class="phabricator-remarkup-mention-unknown">@title</span>:inmenu?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R294 KBookmarks</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D29369">https://phabricator.kde.org/D29369</a></div></div><br \
/><div><strong>To: </strong>kossebau, Frameworks, Localization<br /><strong>Cc: \
</strong>aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]