[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D29153: Move handling of untrusted programs to ApplicationLauncherJob.
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2020-04-28 9:14:10
Message-ID: 25afb8fcf47f0ab3cc2dfd8c2a31abd0 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> applicationlauncherjob.cpp:155
> +    }
> +    proceedAfterSecurityChecks();
> +}

With this it starts to look as hard to follow as KRun :)

REPOSITORY
  R241 KIO

BRANCH
  2020_04_UntrustedProgramHandler

REVISION DETAIL
  https://phabricator.kde.org/D29153

To: dfaure, ahmadsamir, broulik, ngraham, mdlubakowski
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

[Attachment #3 (text/html)]

<table><tr><td style="">broulik accepted this revision.<br />broulik added inline \
comments.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29153">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D29153#inline-167133">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">applicationlauncherjob.cpp:155</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="n">proceedAfterSecurityChecks</span><span class="p">();</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">With \
this it starts to look as hard to follow as KRun \
:)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>2020_04_UntrustedProgramHandler</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D29153">https://phabricator.kde.org/D29153</a></div></div><br \
/><div><strong>To: </strong>dfaure, ahmadsamir, broulik, ngraham, mdlubakowski<br \
/><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, \
bruns<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]