[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: D26877: Simplify calls to whitespace() and use it in more places.
From:       Tomaz Canabrava <tcanabrava () kde ! org>
Date:       2020-02-02 10:38:25
Message-ID: CACk01_ygDsg95Ms26kQiauRmq0TBC7C2iYmwx1adKpp2Fm00uQ () mail ! gmail ! com
[Download RAW message or body]

I like indentedStream.


On Sun, 2 Feb 2020 at 11:36 David Faure <noreply@phabricator.kde.org> wrote:

> dfaure requested changes to this revision.
> dfaure added a comment.
> This revision now requires changes to proceed. View Revision
> <https://phabricator.kde.org/D26877>
>
> I don't like it either. It doesn't "read" well.
> Looking at cout or qDebug it's much more common to [the usual stream] <<
> [some modifier] << some more stuff.
>
> Maybe it can be solved with naming though.
> indentedStream() << ...
> ?
>
> *REPOSITORY*
> R237 KConfig
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D26877
>
> *To: *tcanabrava, dfaure, ervin
> *Cc: *kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
>

[Attachment #3 (text/html)]

<div><div dir="auto">I like indentedStream.</div><div \
dir="auto"><br></div></div><div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sun, 2 Feb 2020 at 11:36 David Faure &lt;<a \
href="mailto:noreply@phabricator.kde.org">noreply@phabricator.kde.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><table><tbody><tr><td>dfaure \
requested changes to this revision.<br>dfaure added a comment.<br>This revision now \
requires changes to proceed. </td><td><a style="text-decoration:none;padding:4px \
8px;margin:0px 8px 8px;float:right;font-weight:bold;border-top-left-radius:3px;border- \
top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;back \
ground-image:linear-gradient(rgb(255,255,255),rgb(241,240,241));display:inline-block;border:1px \
solid rgba(71,87,120,0.2);background-color:rgb(247,247,249);color:rgb(70,76,92)" \
href="https://phabricator.kde.org/D26877" target="_blank">View \
Revision</a></td></tr></tbody></table><br><div><div><p>I don&#39;t like it either. It \
doesn&#39;t &quot;read&quot; well.<br> Looking at cout or qDebug it&#39;s much more \
common to <tt style="font-size:13px;font-family:monospace;background-color:rgb(235,235,235)">[the \
usual stream] &lt;&lt; [some modifier] &lt;&lt; some more stuff</tt>.</p>

<p>Maybe it can be solved with naming though.<br>
indentedStream() &lt;&lt; ... <br>
?</p></div></div><br><div><strong>REPOSITORY</strong><div><div>R237 \
KConfig</div></div></div><br><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D26877" \
target="_blank">https://phabricator.kde.org/D26877</a></div></div><br><div><strong>To: \
</strong>tcanabrava, dfaure, ervin<br><strong>Cc: </strong>kde-frameworks-devel, \
LeGast00n, GB_2, michaelh, ngraham, bruns<br></div></blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]