[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build
From:       Tomaz Canabrava <tcanabrava () kde ! org>
Date:       2020-01-19 16:19:37
Message-ID: CACk01_zWAszt3z8dUAixJKHoji1Hq52FdHSyM7s6_jRWTRmdtA () mail ! gmail ! com
[Download RAW message or body]

I think we are misunderstanding eachother here.
If I'm developing the software and running cmake all the time, having a
warning that I can't fix (because it depends in another platform) is noise,
but still being a developer I don't want to run with -Wno-dev.
I do work in applications that targets more than one system (and they are
mac / windows / ios / android) I tend to use buildhosts, and those
buildhosts will tell me the warning - if any. But only if I'm targeting
them.

I don't see the gain on having a warning - in a windows system, about
missing mac icons if I'm not *deploying*.
nor I do see a warning on a linux system about windows or mac run time
issues (and missing icons is a run time issue).


On Sun, 19 Jan 2020 at 12:03 Tomaz Canabrava <tcanabrava@kde.org> wrote:

> That's not a developer issue, it's a packaging issue.
>
> On Sun, 19 Jan 2020 at 12:02 Christophe Giboudeaux <
> noreply@phabricator.kde.org> wrote:
>
>> cgiboudeaux added a comment. View Revision
>> <https://phabricator.kde.org/D26752>
>>
>> You may use Linux to develop software that's intended to be used also on
>> Mac and Windows. You can't expect developers to have build environment for
>> every platform
>>
>> *REPOSITORY*
>> R240 Extra CMake Modules
>>
>> *REVISION DETAIL*
>> https://phabricator.kde.org/D26752
>>
>> *To: *patrickelectric, apol, tcanabrava, cgiboudeaux
>> *Cc: *apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem,
>> LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
>>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div><div>I think we are misunderstanding eachother here.</div><div>If \
I&#39;m developing the software and running cmake all the time, having a warning that \
I can&#39;t fix (because it depends in another platform) is noise, but still being a \
developer I don&#39;t want to run with -Wno-dev.</div><div>I do work in applications \
that targets more than one system (and they are mac / windows / ios / android) I tend \
to use buildhosts, and those buildhosts will tell me the warning - if any. But only \
if I&#39;m targeting them.</div><div><br></div><div>I don&#39;t see the gain on \
having a warning - in a windows system, about missing mac icons if I&#39;m not \
*deploying*. <br></div><div>nor I do see a warning on a linux system about windows or \
mac run time issues (and missing icons is a run time \
issue).</div><div><br></div></div></div><div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Sun, 19 Jan 2020 at 12:03 Tomaz Canabrava &lt;<a \
href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div \
dir="auto">That's not a developer issue, it's a packaging \
issue.</div></div><div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sun, 19 Jan 2020 at 12:02 Christophe Giboudeaux &lt;<a \
href="mailto:noreply@phabricator.kde.org" \
target="_blank">noreply@phabricator.kde.org</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><table><tbody><tr><td>cgiboudeaux added a comment. \
</td><td><a style="text-decoration:none;padding:4px 8px;margin:0px 8px \
8px;float:right;font-weight:bold;border-radius:3px;background-image:linear-gradient(rgb(255,255,255),rgb(241,240,241));display:inline-block;border:1px \
solid rgba(71,87,120,0.2);background-color:rgb(247,247,249);color:rgb(70,76,92)" \
href="https://phabricator.kde.org/D26752" target="_blank">View \
Revision</a></td></tr></tbody></table><br><div><div><p>You may use Linux to develop \
software that&#39;s intended to be used also on Mac and Windows. You can&#39;t expect \
developers to have build environment for every \
platform</p></div></div><br><div><strong>REPOSITORY</strong><div><div>R240 Extra \
CMake Modules</div></div></div><br><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D26752" \
target="_blank">https://phabricator.kde.org/D26752</a></div></div><br><div><strong>To: \
</strong>patrickelectric, apol, tcanabrava, cgiboudeaux<br><strong>Cc: </strong>apol, \
cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, \
michaelh, ngraham, bruns<br></div></blockquote></div></div> </blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic