[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: D26202: WIP: Refactor KConfigXT
From:       Tomaz Canabrava <tcanabrava () kde ! org>
Date:       2020-01-17 9:41:39
Message-ID: CACk01_y_sMCC_D=B5mqLusm0c4F_3oe4Eu_2__8ECb6KoZwaOw () mail ! gmail ! com
[Download RAW message or body]

We can revert, and I'll fix the full build. Doing that now.

On Fri, 17 Jan 2020 at 09:03 Friedrich W. H. Kossebau <
noreply@phabricator.kde.org> wrote:

> kossebau added a comment. View Revision
> <https://phabricator.kde.org/D26202>
>
> where "full" would also need to mean "clean fresh build dirs" :) so that
> the codegenerator is triggered to be run, as the current cmake code seems
> to not inject a build dep between generator instance and generated files,
> so a new version does not trigger regeneration. Something that could also
> get a fix perhaps, IIRC other tools have such a dep.
>
> *REPOSITORY*
> R237 KConfig
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D26202
>
> *To: *tcanabrava, Frameworks, ervin, bport, dfaure
> *Cc: *kossebau, bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2,
> michaelh, bruns
>

[Attachment #3 (text/html)]

<div><div dir="auto">We can revert, and I'll fix the full build. Doing that now.  \
</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Fri, 17 Jan 2020 at 09:03 Friedrich W. H. Kossebau &lt;<a \
href="mailto:noreply@phabricator.kde.org">noreply@phabricator.kde.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><table><tbody><tr><td>kossebau \
added a comment. </td><td><a style="text-decoration:none;padding:4px 8px;margin:0px \
8px 8px;float:right;font-weight:bold;border-top-left-radius:3px;border-top-right-radiu \
s:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;background-image:linear-gradient(rgb(255,255,255),rgb(241,240,241));display:inline-block;border:1px \
solid rgba(71,87,120,0.2);background-color:rgb(247,247,249);color:rgb(70,76,92)" \
href="https://phabricator.kde.org/D26202" target="_blank">View \
Revision</a></td></tr></tbody></table><br><div><div><p>where &quot;full&quot; would \
also need to mean &quot;clean fresh build dirs&quot; :) so that the codegenerator is \
triggered to be run, as the current cmake code seems to not inject a build dep \
between generator instance and generated files, so a new version does not trigger \
regeneration. Something that could also get a fix perhaps, IIRC other tools have such \
a dep.</p></div></div><br><div><strong>REPOSITORY</strong><div><div>R237 \
KConfig</div></div></div><br><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D26202" \
target="_blank">https://phabricator.kde.org/D26202</a></div></div><br><div><strong>To: \
</strong>tcanabrava, Frameworks, ervin, bport, dfaure<br><strong>Cc: \
</strong>kossebau, bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, \
bruns<br></div></blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]