On Thursday 16 Jan 2020 18:46:06 Kai Uwe Broulik wrote: > Hi, > > for "auto" I think we should always annotate it with const, *, and/or & > where appropriate: > > auto *something = new MyCustomType; > auto *keyEvent = static_cast(event); > const auto myList = QStringList({QLatin1String("FooThing"), > QLatin1String("BarThing")}); This is a bad example of the use of auto. It can be more simply written without using auto: const QStringList myList{QLatin1String("FooThing"), QLatin1String("BarThing")}; > auto &barRef = foo[bar]; > > > The common practice used in KDE seems to be: > > for (a:b) > > +1 > > Cheers > Kai Uwe -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm