[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: D26133: Enable Auto Save
From:       Tomaz Canabrava <tcanabrava () kde ! org>
Date:       2019-12-23 9:16:02
Message-ID: CACk01_w5Tj=2kbLqdyR=eAdTYi_4WrwZBoVzk0oAD+9zumrQfg () mail ! gmail ! com
[Download RAW message or body]

Because not all apps that use KConfigXT use a KCM, and I don't want to make
it necessary to do so. This particular change is done with Kirogi in mind
(that does not uses a KCM, and it's a pure QtQuick / Kirigami app, but uses
KConfigXT)
I'll add the testcase.

On Mon, 23 Dec 2019 at 03:02 Aleix Pol Gonzalez <noreply@phabricator.kde.org>
wrote:

> apol added a comment. View Revision <https://phabricator.kde.org/D26133>
>
> It could make sense to add a test.
>
> Also for an application (system settings or kconfig dialogs) it's already
> possible to just trigger save when the kcm has changed (we already have
> signals for this). Why do you think it's needed?
>
> *REPOSITORY*
> R237 KConfig
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D26133
>
> *To: *tcanabrava
> *Cc: *apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
> bruns
>

[Attachment #3 (text/html)]

<div dir="ltr"><div>Because not all apps that use KConfigXT use a KCM, and I \
don&#39;t want to make it necessary to do so. This particular change is done with \
Kirogi in mind (that does not uses a KCM, and it&#39;s a pure QtQuick / Kirigami app, \
but uses KConfigXT)</div><div>I&#39;ll add the testcase.<br></div></div><div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 23 Dec 2019 at 03:02 \
Aleix Pol Gonzalez &lt;<a href="mailto:noreply@phabricator.kde.org" \
target="_blank">noreply@phabricator.kde.org</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><table><tbody><tr><td>apol added a comment. \
</td><td><a style="text-decoration:none;padding:4px 8px;margin:0px 8px \
8px;float:right;font-weight:bold;border-radius:3px;background-image:linear-gradient(rgb(255,255,255),rgb(241,240,241));display:inline-block;border:1px \
solid rgba(71,87,120,0.2);background-color:rgb(247,247,249);color:rgb(70,76,92)" \
href="https://phabricator.kde.org/D26133" target="_blank">View \
Revision</a></td></tr></tbody></table><br><div><div><p>It could make sense to add a \
test.</p>

<p>Also for an application (system settings or kconfig dialogs) it&#39;s already \
possible to just trigger save when the kcm has changed (we already have signals for \
this). Why do you think it&#39;s \
needed?</p></div></div><br><div><strong>REPOSITORY</strong><div><div>R237 \
KConfig</div></div></div><br><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D26133" \
target="_blank">https://phabricator.kde.org/D26133</a></div></div><br><div><strong>To: \
</strong>tcanabrava<br><strong>Cc: </strong>apol, kde-frameworks-devel, LeGast00n, \
GB_2, michaelh, ngraham, bruns<br></div></blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]