[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D15763: Set correct image attributes on directory thumbnail
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2019-12-13 21:10:38
Message-ID: 41df03c8206b2f539965f0e54ea59486 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> thumbnail.cpp:730
> 
> +                KFileItem item(fileUrl);
> +

For local files, QFileInfo would be more straightforward, no?

You'd just use lastModified() on line 735 and size() on line 736.

KFileItem is mostly meant to encapsulate kioslave listDir/stat results.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15763

To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, \
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, \
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added \
inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15763">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D15763#inline-146288">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">thumbnail.cpp:730</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">                <span \
class="n">KFileItem</span> <span style="color: #004012">item</span><span \
class="p">(</span><span class="n">fileUrl</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">For local files, QFileInfo would be more straightforward, no?</p>

<p style="padding: 0; margin: 8px;">You&#039;d just use lastModified() on line 735 \
and size() on line 736.</p>

<p style="padding: 0; margin: 8px;">KFileItem is mostly meant to encapsulate kioslave \
listDir/stat results.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15763">https://phabricator.kde.org/D15763</a></div></div><br \
/><div><strong>To: </strong>broulik, Frameworks, dfaure, anthonyfieroni, jtamate, \
ngraham<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, kfm-devel, \
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, \
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, \
emmanuelp, mikesomov<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]