[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D24489: KAutosaveFile not respecting maximum filename length
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2019-12-13 20:48:57
Message-ID: 5639e61ac548c54f8f26e009eb1bcadd () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dfaure added a comment.


  It *also* broke Windows compilation:
  
  C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 \
WindowsMSVCQt5.13\src\lib\io\kautosavefile.cpp(79): error C2065: 'NAME_MAX': \
undeclared identifier  
  https://build.kde.org/job/Frameworks/view/Everything%20-%20kf5-qt5/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/


REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D24489">View Revision</a></tr></table><br \
/><div><div><p>It *also* broke Windows compilation:</p>

<p>C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 \
WindowsMSVCQt5.13\src\lib\io\kautosavefile.cpp(79): error C2065: \
&#039;NAME_MAX&#039;: undeclared identifier</p>

<p><a href="https://build.kde.org/job/Frameworks/view/Everything%20-%20kf5-qt5/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://build.kde.org/job/Frameworks/view/Everything%20-%20kf5-qt5/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D24489">https://phabricator.kde.org/D24489</a></div></div><br \
/><div><strong>To: </strong>mardelle, Frameworks, dfaure, mpyne<br /><strong>Cc: \
</strong>ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, \
bruns<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]