[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D24489: KAutosaveFile not respecting maximum filename length
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2019-12-06 21:29:55
Message-ID: 30f453851ff1c60e742865c828704968 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dfaure added a comment.


  I see. This answers my question about why two merge requests -- no problem, keep \
them separate, but commit the fix before the unittest  [this is so that bisecting \
never ends up in the situation where unittests are broken]  
  You can also ignore my suggestion about fileName(QUrl::FullyEncoded) if you're \
afraid it won't be symmetrical, no problem.  
  The rest of mardelle's comment looks sensible to me as well.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D24489">View Revision</a></tr></table><br \
/><div><div><p>I see. This answers my question about why two merge requests -- no \
problem, keep them separate, but commit the fix before the unittest<br /> [this is so \
that bisecting never ends up in the situation where unittests are broken]</p>

<p>You can also ignore my suggestion about fileName(QUrl::FullyEncoded) if \
you&#039;re afraid it won&#039;t be symmetrical, no problem.</p>

<p>The rest of mardelle&#039;s comment looks sensible to me as \
well.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 \
KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D24489">https://phabricator.kde.org/D24489</a></div></div><br \
/><div><strong>To: </strong>mardelle, Frameworks, dfaure, mpyne<br /><strong>Cc: \
</strong>ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, \
bruns<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]