[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D25216: Fix translations of $GenericName
From:       Méven_Car <noreply () phabricator ! kde ! org>
Date:       2019-11-08 17:15:58
Message-ID: ee949183df605a818ddee80e5c241e24 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

meven added a comment.


  In D25216#560212 <https://phabricator.kde.org/D25216#560212>, @aspotashev wrote:
  
  > LGTM since it fixes the issue.
  >
  > A next step could be a clearer explaination of what $GenericName will be replaced \
with. Is it always replaced with Filelight's GenericName from its filelight.desktop \
file?  
  
  Yes, it uses KMoreToolsService::formatString to replace $GenericName with content \
from its desktop file.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization, aspotashev
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


[Attachment #3 (text/html)]

<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D25216">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D25216#560212" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D25216#560212</a>, <a \
href="https://phabricator.kde.org/p/aspotashev/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aspotashev</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>LGTM since it fixes the issue.</p>

<p>A next step could be a clearer explaination of what $GenericName will be replaced \
with. Is it always replaced with Filelight&#039;s GenericName from its \
filelight.desktop file?</p></div> </blockquote>

<p>Yes, it uses KMoreToolsService::formatString to replace $GenericName with content \
from its desktop file.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>arcpatch-D25216</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D25216">https://phabricator.kde.org/D25216</a></div></div><br \
/><div><strong>To: </strong>meven, leinir, ngraham, Localization, aspotashev<br \
/><strong>Cc: </strong>aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, \
ngraham, bruns<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]