[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2019-07-31 12:37:14
Message-ID: 527c4a991a3fa37abdc18bbcadf9290a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added inline comments.

INLINE COMMENTS

> containmentinterface.cpp:1225
> +    if (m_wallpaperInterface) {
> +        loading &= m_wallpaperInterface->isLoading();
> +    }

Shouldn't this be `|=`?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22852

To: davidedmundson, #plasma
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D22852">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D22852#inline-128954">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">containmentinterface.cpp:1225</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">m_wallpaperInterface</span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">loading</span> <span style="color: \
#aa2211">&amp;=</span> <span class="n">m_wallpaperInterface</span><span style="color: \
#aa2211">-&gt;</span><span class="n">isLoading</span><span class="p">();</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Shouldn&#039;t this be <tt style="background: #ebebeb; font-size: \
13px;">|=</tt>?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D22852">https://phabricator.kde.org/D22852</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, \
apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]