[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2019-07-31 11:29:15
Message-ID: e37294e10803656c1a24d3b734eb0e6e () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.
Version 2 of the patch using a normal property.
We need to have the virtual so that the containment waits for the
wallpaper.
TEST PLAN
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper is pushed
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22852
AFFECTED FILES
src/scriptengines/qml/plasmoid/appletinterface.cpp
src/scriptengines/qml/plasmoid/appletinterface.h
src/scriptengines/qml/plasmoid/containmentinterface.cpp
src/scriptengines/qml/plasmoid/containmentinterface.h
src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
src/scriptengines/qml/plasmoid/wallpaperinterface.h
To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Herald added a project: Frameworks.<br />Herald added \
a subscriber: kde-frameworks-devel.<br />davidedmundson requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D22852">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>This is needed so that we don't \
remove the splash till the wallpaper is<br /> loaded, but also allows doing this in a \
generic way.</p>
<p>Version 2 of the patch using a normal property.</p>
<p>We need to have the virtual so that the containment waits for the<br />
wallpaper.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Used with \
wallpaper patch<br /> Added debug to ensure it happened after the stackview in the \
wallpaper is pushed</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D22852">https://phabricator.kde.org/D22852</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/scriptengines/qml/plasmoid/appletinterface.cpp<br /> \
src/scriptengines/qml/plasmoid/appletinterface.h<br /> \
src/scriptengines/qml/plasmoid/containmentinterface.cpp<br /> \
src/scriptengines/qml/plasmoid/containmentinterface.h<br /> \
src/scriptengines/qml/plasmoid/wallpaperinterface.cpp<br /> \
src/scriptengines/qml/plasmoid/wallpaperinterface.h</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic