[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D10747: Implement zwp_linux_dmabuf_v1
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2019-07-17 13:53:34
Message-ID: c8fb357b9f8048a7404308d1c6cc3da9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

romangg added a comment.


  If there are no objections I would push this soon.
  
  There is one remaining annoyance I have with the current version: the name of the \
class inside the interface the compositor has to subclass for interfacing with \
KWayland. I changed the name from Bridge to Impl since Bridge can be anything and as \
we use the name Impl in KWin already for stuff like this. But there it's used for the \
subclass and not for the abstract implementation base class. Any other idea for a \
good name?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: zzag, kde-frameworks-devel, romangg, plasma-devel, LeGast00n, fmonteiro, \
sbergeron, hannahk, jraleigh, sgureev, fbampaloukas, GB_2, ragreen, Pitel, \
schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (text/html)]

<table><tr><td style="">romangg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10747">View Revision</a></tr></table><br \
/><div><div><p>If there are no objections I would push this soon.</p>

<p>There is one remaining annoyance I have with the current version: the name of the \
class inside the interface the compositor has to subclass for interfacing with \
KWayland. I changed the name from Bridge to Impl since Bridge can be anything and as \
we use the name Impl in KWin already for stuff like this. But there it&#039;s used \
for the subclass and not for the abstract implementation base class. Any other idea \
for a good name?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 \
KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10747">https://phabricator.kde.org/D10747</a></div></div><br \
/><div><strong>To: </strong>romangg, KWin, Plasma, graesslin, davidedmundson, mart, \
fredrik<br /><strong>Cc: </strong>zzag, kde-frameworks-devel, romangg, plasma-devel, \
LeGast00n, fmonteiro, sbergeron, hannahk, jraleigh, sgureev, fbampaloukas, GB_2, \
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]