[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D11235: [DrKonqi] Request change of ptrace scope from KCrash
From:       Oswald Buddenhagen <noreply () phabricator ! kde ! org>
Date:       2019-01-17 12:07:39
Message-ID: 5498a0e6e10e2dc60aaf51e64bf94335 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ossi added a comment.


  you got the parent-child ordering wrong in the commit message. ^^

INLINE COMMENTS

> ptracer.cpp:61
> +        char msg[msize], rmsg[msize];
> +        int bytes = 0, r;
> +        sprintf(msg, "%lld", debuggerpid);

this looks stupid, i'd swap the order.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, \
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ossi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11235">View Revision</a></tr></table><br \
/><div><div><p>you got the parent-child ordering wrong in the commit message. \
^^</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: \
6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; \
padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11235#inline-101299">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ptracer.cpp:61</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #aa4000">char</span> <span class="n">msg</span><span \
class="p">[</span><span class="n">msize</span><span class="p">],</span> <span \
class="n">rmsg</span><span class="p">[</span><span class="n">msize</span><span \
class="p">];</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span style="color: #aa4000">int</span> <span \
class="n">bytes</span> <span style="color: #aa2211">=</span> <span style="color: \
#601200">0</span><span class="p">,</span> <span class="n">r</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">sprintf</span><span \
class="p">(</span><span class="n">msg</span><span class="p">,</span> <span \
style="color: #766510">&quot;%lld&quot;</span><span class="p">,</span> <span \
class="n">debuggerpid</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
looks stupid, i&#039;d swap the order.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11235">https://phabricator.kde.org/D11235</a></div></div><br \
/><div><strong>To: </strong>croick, Plasma: Workspaces, Frameworks, ossi<br \
/><strong>Cc: </strong>ossi, lepagevalleeemmanuel, maximilianocuria, adridg, \
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]