[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D11235: [DrKonqi] Request change of ptrace scope from KCrash
From:       Christoph Roick <noreply () phabricator ! kde ! org>
Date:       2019-01-16 16:15:47
Message-ID: 512b22895437a7efe1c5655c0d26e6fb () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

croick added inline comments.

INLINE COMMENTS

> ossi wrote in ptracer.cpp:65
> you really could just use != here ... ^^

wow...

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, \
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">croick added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11235">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11235#inline-101178">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ossi</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">ptracer.cpp:65</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">you really \
could just use != here ... ^^</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: \
8px;">wow...</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11235">https://phabricator.kde.org/D11235</a></div></div><br \
/><div><strong>To: </strong>croick, Plasma: Workspaces, Frameworks, ossi<br \
/><strong>Cc: </strong>ossi, lepagevalleeemmanuel, maximilianocuria, adridg, \
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]