[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D11235: [DrKonqi] Request change of ptrace scope from KCrash
From:       Christoph Roick <noreply () phabricator ! kde ! org>
Date:       2019-01-16 12:11:03
Message-ID: 984495cde061eed6908bb1fcd80456c3 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

croick marked 11 inline comments as done.
croick added a comment.


  `read()` and `write()` were assumed to work right away, I added a loop around.

INLINE COMMENTS

> ossi wrote in crashtest.cpp:133
> this addition isn't used or explained anywhere for all i can tell.

It's used to unset the `AlwaysDirectly` flag. It allows testing using with direct \
start and kdeinit start.

> ossi wrote in crashtest.cpp:138
> only if kdeinit was started from the same console, which you cannot assume.
> 
> also, this change wouldn't belong into this patch anyway.

Agreed, I added an option instead and would commit that separately.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, \
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">croick marked 11 inline comments as done.<br />croick added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11235">View Revision</a></tr></table><br \
/><div><div><p><tt style="background: #ebebeb; font-size: 13px;">read()</tt> and <tt \
style="background: #ebebeb; font-size: 13px;">write()</tt> were assumed to work right \
away, I added a loop around.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11235#inline-101098">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ossi</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">crashtest.cpp:133</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">this \
addition isn&#039;t used or explained anywhere for all i can tell.</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">It&#039;s used to unset the <tt style="background: #ebebeb; font-size: \
13px;">AlwaysDirectly</tt> flag. It allows testing using with direct start and \
kdeinit start.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D11235#inline-100721">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ossi</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">crashtest.cpp:138</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">only if \
kdeinit was started from the same console, which you cannot assume.</p>

<p style="padding: 0; margin: 8px;">also, this change wouldn&#039;t belong into this \
patch anyway.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Agreed, I added an option instead and would commit \
that separately.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11235">https://phabricator.kde.org/D11235</a></div></div><br \
/><div><strong>To: </strong>croick, Plasma: Workspaces, Frameworks, ossi<br \
/><strong>Cc: </strong>ossi, lepagevalleeemmanuel, maximilianocuria, adridg, \
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]