[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: D11235: [DrKonqi] Request change of ptrace scope from KCrash
From: Christoph Roick <noreply () phabricator ! kde ! org>
Date: 2019-01-16 10:14:38
Message-ID: ddcf0a2efd315a98b8b54236eb49e804 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
croick updated this revision to Diff 49607.
croick edited the summary of this revision.
croick edited the test plan for this revision.
croick added a comment.
- rename queryPtrace to setPtracer
- add a kdeinit option in crashtest
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11235?vs=34671&id=49607
BRANCH
ptracer
REVISION DETAIL
https://phabricator.kde.org/D11235
AFFECTED FILES
src/CMakeLists.txt
src/debuggerlaunchers.cpp
src/debuggerlaunchers.h
src/ptracer.cpp
src/ptracer.h
src/tests/crashtest/crashtest.cpp
To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, \
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">croick updated this revision to Diff 49607.<br />croick \
edited the summary of this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-5mt643kdda6fegg/">(Show \
Details)</a><br />croick edited the test plan for this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-qven2gxzoeixkp7/">(Show \
Details)</a><br />croick added a comment. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11235">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">rename \
queryPtrace to setPtracer</li> <li class="remarkup-list-item">add a kdeinit option in \
crashtest</li> </ul></div></div><br /><div><strong>CHANGES TO REVISION \
SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span \
style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">- \
In</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, \
.6);">- On</span> Linux recent kernels only allow attaching of processes<div \
style="padding: 8px 0;">...</div> <span style="padding: 0 2px; color: #333333; \
background: rgba(251, 175, 175, .7);">*</span><span style="padding: 0 2px; color: \
#333333; background: rgba(151, 234, 151, .6);">* or</span> the debugge<span \
style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">r is a \
child pro</span><span style="padding: 0 2px; color: #333333; background: rgba(151, \
234, 151, .6);">e grants ac</span>cess <span style="padding: 0 2px; color: #333333; \
background: rgba(251, 175, 175, .7);">of the debuggee</span><span style="padding: 0 \
2px; color: #333333; background: rgba(151, 234, 151, .6);">by a call to</span><br /> \
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* \
or the debuggee grants access by a call to</span><span style="padding: 0 2px; color: \
#333333; background: rgba(151, 234, 151, .6);"> `prctl(PR_SET_PTRACER, debugger_pid, \
0, 0, 0);`</span><br /> <span style="padding: 0 2px; color: #333333; background: \
rgba(251, 175, 175, .7);"> prctl(PR_SET_PTRACER,</span><span style="padding: 0 \
2px; color: #333333; background: rgba(151, 234, 151, .6);">- DrKonqi will ask \
the</span> debugge<span style="padding: 0 2px; color: #333333; background: rgba(251, \
175, 175, .7);">r_pid, 0, 0, 0);<br />
- DrKonqi cannot do this directly,</span><span style="padding: 0 2px; color: #333333; \
background: rgba(151, 234, 151, .6);">e by a socket connection to<br /> set a new \
ptracer.</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, \
175, 175, .7);">so it will ask the</span><span style="padding: 0 2px; color: #333333; \
background: rgba(151, 234, 151, .6);">This is required if an external \
debugger</span><br /> <span style="padding: 0 2px; color: #333333; background: \
rgba(251, 175, 175, .7);">debuggee to do so by a socket connection</span><span \
style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">is \
started (using the usually hidden Debug button)</span>.<div style="padding: 8px \
0;">...</div></div></div></div><br /><div><strong>CHANGES TO TEST \
PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div \
style="padding: 8px 0;">...</div> using the <span style="padding: 0 2px; color: \
#333333; background: rgba(251, 175, 175, .7);">d</span><span style="padding: 0 2px; \
color: #333333; background: rgba(151, 234, 151, .6);">D</span>ebug button: operation \
will not be permitted<div style="padding: 8px 0;">...</div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D11235?vs=34671&id=49607">https://phabricator.kde.org/D11235?vs=34671&id=49607</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>ptracer</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11235">https://phabricator.kde.org/D11235</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br /> \
src/debuggerlaunchers.cpp<br /> src/debuggerlaunchers.h<br />
src/ptracer.cpp<br />
src/ptracer.h<br />
src/tests/crashtest/crashtest.cpp</div></div></div><br /><div><strong>To: \
</strong>croick, Plasma: Workspaces, Frameworks, ossi<br /><strong>Cc: </strong>ossi, \
lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic