[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: D7038: [server] Respect input region of sub-surfaces on pointer surface focus
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-09-27 21:20:24
Message-ID: 1f68dff56e997a714b22a1844df7a267 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I've written you a unit test.
I can either take over this or upload as a separate review that you can merge in.
INLINE COMMENTS
> zzag wrote in surface_interface.cpp:819
> So, it would be fine to return `true` in the following case:
>
> QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10));
>
> ?
I would have said so.
But then it means sizeContains and inputContains behave differently as
QRegion(QRect(0,0,10,10)).contains(10,10); returns false
which gives us some inconsistency.
> surface_interface.cpp:824
> {
> - if (!isMapped()) {
> + return sizeContains(size, QRegion(), position) && \
> input.contains(position.toPoint()); +}
This needs to be
&& (surface.inputIsInfinite() || input.contains(..))
which means either an extra arg in our function pointer or go back to the frankly \
simpler first revision. Writing N complex lines to save duplicating N simple lines \
doesn't make much sense to me, especially when they end up deviating.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, ragreen, \
Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added a comment.<br />This revision now requires changes to proceed. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7038">View Revision</a></tr></table><br \
/><div><div><p>I've written you a unit test.</p>
<p>I can either take over this or upload as a separate review that you can merge \
in.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7038#inline-83461">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">surface_interface.cpp:819</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">So, it would be fine to return <tt style="background: #ebebeb; \
font-size: 13px;">true</tt> in the following case:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span \
class="n">QRectF</span><span class="p">(</span><span class="n">QPoint</span><span \
class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span \
style="color: #601200">0</span><span class="p">),</span> <span \
class="n">QSize</span><span class="p">(</span><span style="color: \
#601200">10</span><span class="p">,</span> <span style="color: \
#601200">10</span><span class="p">)).</span><span class="n">contains</span><span \
class="p">(</span><span class="n">QPointF</span><span class="p">(</span><span \
style="color: #601200">10</span><span class="p">,</span> <span style="color: \
#601200">10</span><span class="p">));</span></pre></div>
<p style="padding: 0; margin: 8px;">?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
would have said so.</p>
<p style="padding: 0; margin: 8px;">But then it means sizeContains and inputContains \
behave differently as</p>
<p style="padding: 0; margin: 8px;">QRegion(QRect(0,0,10,10)).contains(10,10); \
returns false</p>
<p style="padding: 0; margin: 8px;">which gives us some \
inconsistency.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D7038#inline-85430">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">surface_interface.cpp:824</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);"> <span class="bright"></span><span style="color: #aa4000"><span \
class="bright">if</span></span><span class="bright"> </span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">!</span></span><span class="bright"></span><span \
class="n"><span class="bright">isMapped</span></span><span \
class="bright"></span><span class="p"><span class="bright">())</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="bright"></span><span style="color: #aa4000"><span \
class="bright">return</span></span><span class="bright"> </span><span class="n"><span \
class="bright">sizeContains</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">size</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
class="n"><span class="bright">QRegion</span></span><span class="bright"></span><span \
class="p"><span class="bright">(),</span></span><span class="bright"> </span><span \
class="n"><span class="bright">position</span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">&&</span></span><span class="bright"> </span><span \
class="n"><span class="bright">input</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">contains</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">position</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">toPoint</span></span><span class="bright"></span><span \
class="p"><span class="bright">());</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This needs to be</p>
<p style="padding: 0; margin: 8px;">&& (surface.inputIsInfinite() || \
input.contains(..))</p>
<p style="padding: 0; margin: 8px;">which means either an extra arg in our function \
pointer or go back to the frankly simpler first revision. Writing N complex lines to \
save duplicating N simple lines doesn't make much sense to me, especially when \
they end up deviating.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7038">https://phabricator.kde.org/D7038</a></div></div><br \
/><div><strong>To: </strong>romangg, Frameworks, graesslin, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, zzag, kde-frameworks-devel, graesslin, \
plasma-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, \
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, \
mart, hein<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic