[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D7038: [server] Respect input region of sub-surfaces on pointer surface focus
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-09-14 7:18:42
Message-ID: b7abde5931982e5498f37de2299ab48c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

zzag added inline comments.

INLINE COMMENTS

> surface_interface.cpp:819
> +
> +    return !size.isEmpty() && QRectF(QPoint(0, 0), size).contains(position);
> +}

Shouldn't it be QRect instead?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin
Cc: zzag, kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel, schernikov, \
michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (text/html)]

<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7038">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7038#inline-83439">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">surface_interface.cpp:819</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">    <span style="color: #aa4000">return</span> <span style="color: \
#aa2211">!</span><span class="n">size</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">()</span> <span style="color: \
#aa2211">&amp;&amp;</span> <span class="n">QRectF</span><span class="p">(</span><span \
class="n">QPoint</span><span class="p">(</span><span style="color: \
#601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span \
class="p">),</span> <span class="n">size</span><span class="p">).</span><span \
class="n">contains</span><span class="p">(</span><span class="n">position</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Shouldn&#039;t it be QRect instead?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7038">https://phabricator.kde.org/D7038</a></div></div><br \
/><div><strong>To: </strong>romangg, Frameworks, graesslin<br /><strong>Cc: \
</strong>zzag, kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel, \
schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]