[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D10040: Add serial number and EISA ID to OutputDevice interface
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-07-30 12:30:48
Message-ID: 26e7d3450ca145e230986377c61827c9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

romangg added inline comments.

INLINE COMMENTS

> outputdevice.cpp:161
> +                              int32_t subPixel, const char *make, const char \
> *model, +                              int32_t transform)
> {

Unrelated change.

> outputdevice_interface.cpp:153
> +    connect(this, &OutputDeviceInterface::serialNumberChanged,   this, [this, d] { \
> d->updateGeometry(); }); +    connect(this, &OutputDeviceInterface::eisaIdChanged,  \
> this, [this, d] { d->updateGeometry(); }); connect(this, \
> &OutputDeviceInterface::scaleChanged,          this, [this, d] { d->updateScale(); \
> });

needs fix

> outputdevice_interface.cpp:410
> +    wl_resource_post_event(resource,
> +                            ORG_KDE_KWIN_OUTPUTDEVICE_GEOMETRY,
> globalPosition.x(),

Why change? Unrelated.

> outputdevice_interface.h:50
> +//KF6 TODO - This class sends absolute garbage over the wire constantly.
> +//sendDone needs to be explicit, anything related to the geometry event needs to \
> be in a single method +

What do you mean with "needs to be explicit"?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10040

To: davidedmundson, graesslin, sebas, #kwin, dvratil
Cc: romangg, kde-frameworks-devel, davidedmundson, plasma-devel, ragreen, Pitel, \
schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (text/html)]

<table><tr><td style="">romangg added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10040">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10040#inline-76383">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">outputdevice.cpp:161</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">          \
<span style="color: #aa4000">int32_t</span> <span class="n">subPixel</span><span \
class="p">,</span> <span style="color: #aa4000">const</span> <span style="color: \
#aa4000">char</span> <span style="color: #aa2211">*</span><span \
class="n">make</span><span class="p">,</span> <span style="color: \
#aa4000">const</span> <span style="color: #aa4000">char</span> <span style="color: \
#aa2211">*</span><span class="n">model</span><span class="p">,<span \
class="bright"></span></span><span class="bright"> </span><span style="color: \
#aa4000"><span class="bright">int32_t</span></span><span class="bright"> </span><span \
class="n"><span class="bright">transform</span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #aa4000">int32_t</span> <span class="n">subPixel</span><span \
class="p">,</span> <span style="color: #aa4000">const</span> <span style="color: \
#aa4000">char</span> <span style="color: #aa2211">*</span><span \
class="n">make</span><span class="p">,</span> <span style="color: \
#aa4000">const</span> <span style="color: #aa4000">char</span> <span style="color: \
#aa2211">*</span><span class="n">model</span><span class="p">,</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #aa4000">int32_t</span> <span class="n">transform</span><span \
class="p">)</span> </div><div style="padding: 0 8px; margin: 0 4px; "><span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Unrelated change.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D10040#inline-76385">View Inline</a><span \
style="color: #4b4d51; font-weight: \
bold;">outputdevice_interface.cpp:153</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">connect</span><span class="p">(</span><span style="color: \
#aa4000">this</span><span class="p">,</span> <span style="color: \
#aa2211">&amp;</span><span class="n">OutputDeviceInterface</span><span style="color: \
#aa2211">::</span><span class="n">serialNumberChanged</span><span class="p">,</span>  \
<span style="color: #aa4000">this</span><span class="p">,</span> <span \
class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> \
<span class="n">d</span><span class="p">]</span> <span class="p">{</span> <span \
class="n">d</span><span style="color: #aa2211">-&gt;</span><span \
class="n">updateGeometry</span><span class="p">();</span> <span class="p">});</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="n">connect</span><span class="p">(</span><span style="color: \
#aa4000">this</span><span class="p">,</span> <span style="color: \
#aa2211">&amp;</span><span class="n">OutputDeviceInterface</span><span style="color: \
#aa2211">::</span><span class="n">eisaIdChanged</span><span class="p">,</span>        \
<span style="color: #aa4000">this</span><span class="p">,</span> <span \
class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> \
<span class="n">d</span><span class="p">]</span> <span class="p">{</span> <span \
class="n">d</span><span style="color: #aa2211">-&gt;</span><span \
class="n">updateGeometry</span><span class="p">();</span> <span class="p">});</span> \
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span \
class="n">connect</span><span class="p">(</span><span style="color: \
#aa4000">this</span><span class="p">,</span> <span style="color: \
#aa2211">&amp;</span><span class="n">OutputDeviceInterface</span><span style="color: \
#aa2211">::</span><span class="n">scaleChanged</span><span class="p">,</span>         \
<span style="color: #aa4000">this</span><span class="p">,</span> <span \
class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> \
<span class="n">d</span><span class="p">]</span> <span class="p">{</span> <span \
class="n">d</span><span style="color: #aa2211">-&gt;</span><span \
class="n">updateScale</span><span class="p">();</span> <span class="p">});</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">needs fix</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D10040#inline-76386">View Inline</a><span \
style="color: #4b4d51; font-weight: \
bold;">outputdevice_interface.cpp:410</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
class="bright"></span><span class="n"><span \
class="bright">org_kde_kwin_outputdevice_send_geometry</span></span><span \
class="p">(</span><span class="n">resource</span><span class="p">,</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="bright"></span><span class="n"><span \
class="bright">wl_resource_post_event</span></span><span class="p">(</span><span \
class="n">resource</span><span class="p">,</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">                            \
<span class="n">ORG_KDE_KWIN_OUTPUTDEVICE_GEOMETRY</span><span class="p">,</span> \
</div><div style="padding: 0 8px; margin: 0 4px; ">                            <span \
class="n">globalPosition</span><span class="p">.</span><span class="n">x</span><span \
class="p">(),</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why \
change? Unrelated.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D10040#inline-76387">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">outputdevice_interface.h:50</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"><span style="color: #74777d">//KF6 TODO - This class sends absolute \
garbage over the wire constantly.</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">//sendDone \
needs to be explicit, anything related to the geometry event needs to be in a single \
method</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What \
do you mean with &quot;needs to be \
explicit&quot;?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10040">https://phabricator.kde.org/D10040</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, graesslin, sebas, KWin, dvratil<br \
/><strong>Cc: </strong>romangg, kde-frameworks-devel, davidedmundson, plasma-devel, \
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]