[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D14434: add functions to access keywords
From:       Alexander Semke <noreply () phabricator ! kde ! org>
Date:       2018-07-29 16:18:38
Message-ID: ee5f17e12ca2141d044605d893164644 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

asemke added a comment.


  In D14434#299932 <https://phabricator.kde.org/D14434#299932>, @dhaumann wrote:
  
  > In general looks good to me, so +1. I would like to have another +1 from \
@cullmann, @vkrause or @asemke  
  
  +1
  
  > What I wonder is whether you really need the keyword lists from the Definition, \
or whether you want the currently active keyword lists from the current State / \
Context. I can see that both is useful.  
  As just replied to the mailing list, both would be useful. But let's do this maybe \
step by step. With this change T4760 <https://phabricator.kde.org/T4760> will become \
possible. After this I'll have a look at how to simplify the completion logic in \
Cantor.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, \
kevinapavew, ngraham, bruns, demsking, sars, dhaumann


[Attachment #3 (text/html)]

<table><tr><td style="">asemke added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14434">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D14434#299932" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D14434#299932</a>, <a \
href="https://phabricator.kde.org/p/dhaumann/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@dhaumann</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>In general looks good to me, so +1. I would \
like to have another +1 from <a href="https://phabricator.kde.org/p/cullmann/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@cullmann</a>, <a \
href="https://phabricator.kde.org/p/vkrause/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@vkrause</a> or <a \
href="https://phabricator.kde.org/p/asemke/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@asemke</a></p></div>
</blockquote>

<p>+1</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>What \
I wonder is whether you really need the keyword lists from the Definition, or whether \
you want the currently active keyword lists from the current State / Context. I can \
see that both is useful.</p></blockquote>

<p>As just replied to the mailing list, both would be useful. But let&#039;s do this \
maybe step by step. With this change <a href="https://phabricator.kde.org/T4760" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">T4760</a> will become possible. After \
this I&#039;ll have a look at how to simplify the completion logic in \
Cantor.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax \
Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14434">https://phabricator.kde.org/D14434</a></div></div><br \
/><div><strong>To: </strong>jpoelen, Framework: Syntax Highlighting, dhaumann<br \
/><strong>Cc: </strong>vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, \
michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]