[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D13752: Kill solidautoeject
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-06-27 11:10:39
Message-ID: 7792bfabca29171ab5466323739602b4 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added a comment.


  > It's not clear to me what this revision is trying to change (in terms of \
user-visible behavior) or how to test the change  
  I think you could test it by disabling the "Drive Ejector" module in "Background \
Services" (kded settings) in System Settings. If pressing the button still ejects the \
CD as before, then this patch should be good on BSD / with HAL also.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13752">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>It&#039;s not clear to me what this revision is trying to change (in \
terms of user-visible behavior) or how to test the change</p></blockquote>

<p>I think you could test it by disabling the &quot;Drive Ejector&quot; module in \
&quot;Background Services&quot; (kded settings) in System Settings. If pressing the \
button still ejects the CD as before, then this patch should be good on BSD / with \
HAL also.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13752">https://phabricator.kde.org/D13752</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Frameworks, adridg, davidedmundson, \
dfaure, fvogt, ervin<br /><strong>Cc: </strong>mart, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]