From kde-frameworks-devel  Wed May 30 12:01:39 2018
From: =?UTF-8?B?SXZhbiDEjHVracSH?= <ivan.cukic () kde ! org>
Date: Wed, 30 May 2018 12:01:39 +0000
To: kde-frameworks-devel
Subject: Re: bic in kactivities
Message-Id: <CAAWhJrwyh=5aB41=R3-KHiT__uosrgV7JqiGu_wOc=CZGyTmVg () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=152768174209292

Marco, thanks for reverting this.

@Laurent

The proper change for the constructor should be to make the Private class
take the shownStates by value (a sink constructor argument) and for the
ActivitiesModel constructor to std::move it when passing to the Private
constructor.

@All

- ` explicit` should not change the ABI (will have to check just in case)
- The second change that shouldn't be a problem is that
src/imports/resourcemodel.h does not need to keep ABI  - it not exported as
a normal library, it is a QML type.

This does not need the FIXME KF6 tag, the API is as it should be,

Cheers,
Ivan