[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: bic in kactivities
From:       Christoph Feck <cfeck () kde ! org>
Date:       2018-05-30 9:48:41
Message-ID: bcf5eceb-919d-2237-6a42-00f3e9ae1838 () kde ! org
[Download RAW message or body]

On 30.05.2018 10:13, Harald Sitter wrote:
> Salut!
> 
> https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1
>  
> It appears to me that this is a binary incompatible change.
> 
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
> > You cannot...For existing functions of any type:change its signature. This \
> > includes:changing any of the types of the arguments in the parameter list, \
> > including changing the const/volatile qualifiers of the existing parameters \
> > (instead, add a new method)

Worse: The commit does not only add a 'const', but converts the argument 
from an object to a reference to the object.


[prev in list] [next in list] [prev in thread] [next in thread]