[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D12388: Output device color curves correction
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-05-04 0:56:03
Message-ID: 20180504005603.1.ED27F38D8DC5E35D () phabricator ! kde ! org
[Download RAW message or body]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in outputconfiguration_interface.cpp:221
> constify wl_array?
> constify pos, e.g. `uint16_t const *pos`?

You can resize v and call memcpy (or use std::copy?)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson, graesslin
Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns

[Attachment #3 (unknown)]

<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12388">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12388#inline-64965">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">outputconfiguration_interface.cpp:221</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">constify wl_array?<br /> constify pos, e.g. <tt style="background: #ebebeb; \
font-size: 13px;">uint16_t const *pos</tt>?</p></div></div> <div style="margin: 8px \
0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can resize v and call \
memcpy (or use std::copy?)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12388">https://phabricator.kde.org/D12388</a></div></div><br \
/><div><strong>To: </strong>romangg, Frameworks, davidedmundson, graesslin<br \
/><strong>Cc: </strong>graesslin, davidedmundson, zzag, cfeck, michaelh, bruns<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]