[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D12321: Hide file preview when icon is too small
From:       Mark Gaiser <noreply () phabricator ! kde ! org>
Date:       2018-04-23 17:04:42
Message-ID: 20180423170442.1.9C72799343EE5850 () phabricator ! kde ! org
[Download RAW message or body]

markg added a comment.


  In D12321#252393 <https://phabricator.kde.org/D12321#252393>, @rkflx wrote:
  
  > In D12321#252374 <https://phabricator.kde.org/D12321#252374>, @markg wrote:
  >
  > > The blown up way of looking at it (resized version) does not give you an \
accurate representation of how it will look like in the native size.  >
  >
  > Have you actually tried the patch? Raster icons are not blown up, they are shown \
at their native size as long as it is smaller than the grid spacing (and the grid \
spacing is large enough to enable showing of previews).  
  
  I've not tried this patch nor the svg patch.
  The perfect video of this patch clearly shows me what i need to see (big pros for \
that btw!).  The svg patch unlikely influences my png icons ;)
  
  My comment was based on what i see in an icon folder right in front of me at this \
very moment.  16x16 icons are scaled to whatever the zoom level is (which is fine \
imho). These icons are png ones.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg
Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns


[Attachment #3 (unknown)]

<table><tr><td style="">markg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12321">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D12321#252393" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D12321#252393</a>, <a \
href="https://phabricator.kde.org/p/rkflx/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D12321#252374" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D12321#252374</a>, <a \
href="https://phabricator.kde.org/p/markg/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@markg</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>The blown up way of looking at it (resized \
version) does not give you an accurate representation of how it will look like in the \
native size.</p></div> </blockquote>

<p>Have you actually tried the patch? Raster icons are not blown up, they are shown \
at their native size as long as it is smaller than the grid spacing (and the grid \
spacing is large enough to enable showing of previews).</p></div> </blockquote>

<p>I&#039;ve not tried this patch nor the svg patch.<br />
The perfect video of this patch clearly shows me what i need to see (big pros for \
that btw!).<br /> The svg patch unlikely influences my png icons ;)</p>

<p>My comment was based on what i see in an icon folder right in front of me at this \
very moment.<br /> 16x16 icons are scaled to whatever the zoom level is (which is \
fine imho). These icons are png ones.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12321">https://phabricator.kde.org/D12321</a></div></div><br \
/><div><strong>To: </strong>anemeth, VDG, Frameworks, ngraham, rkflx, Dolphin, \
markg<br /><strong>Cc: </strong>markg, xyquadrat, sharvey, rkflx, ngraham, \
Frameworks, michaelh, bruns<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]