[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: D11569: Improve consistency of "Open With" UI by always showing top app inline
From: Nathaniel Graham <noreply () phabricator ! kde ! org>
Date: 2018-03-22 18:06:21
Message-ID: 20180322180621.1.4D256EDC7F9BFA3F () phabricator ! kde ! org
[Download RAW message or body]
ngraham added a comment.
In D11569#231663 <https://phabricator.kde.org/D11569#231663>, @mmustac wrote:
> I have two questions regarding this "open with" topic.
> Is the displayed app the one which is also set as default for this file type or \
the first alternative (2nd app) ? If it's the default one why should someone make a \
right click on a file to open it with his/her default app instead of making a \
single/double click on it?
It's rather odd that there's no Open item in Dolphin's context menu in the first \
place, and this patch remedies that. Also, this is a general API, so other clients \
can potentially benefit from it even when it's not used in a context menu. (e.g. \
Gwenview could adopt this to make it easier to open images in other apps, where \
currently the only option is to use a sub-menu)
> The second point: Shouldn't the "Open with" stuff be at the very beginning of the \
menu when we have a file selected for quick access? (1. opening, 2. create new files \
(for folders), 3. direct file operations, 4. additional file operations, 5. \
everything else)
I would approve of that. It's what macOS does, FWIW:
F5762927: finder menu.png <https://phabricator.kde.org/F5762927>
As you can see from the above image, macOS doesn't tell you what app will launch in \
response to the Open action, so this patch would actually represent a usability \
improvement over that. However, re-ordering the menu would need to be changed in \
Dolphin, not here in KIO. That change (if we do it) should go into 18.08.0, to make \
sure that it can rely on this change (if it's accepted).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11569
To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, \
abetts, michaelh, ngraham
[Attachment #3 (unknown)]
<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11569">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11569#231663" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11569#231663</a>, <a \
href="https://phabricator.kde.org/p/mmustac/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mmustac</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I have two questions regarding this \
"open with" topic.<br /> Is the displayed app the one which is also set as \
default for this file type or the first alternative (2nd app) ? If it's the \
default one why should someone make a right click on a file to open it with his/her \
default app instead of making a single/double click on it?</p></div> </blockquote>
<p>It's rather odd that there's no <span><span class="phui-tag-view \
phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core \
">Open</span></span></span> item in Dolphin's context menu in the first place, \
and this patch remedies that. Also, this is a general API, so other clients can \
potentially benefit from it even when it's not used in a context menu. (e.g. \
Gwenview could adopt this to make it easier to open images in other apps, where \
currently the only option is to use a sub-menu)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The \
second point: Shouldn't the "Open with" stuff be at the very beginning \
of the menu when we have a file selected for quick access? (1. opening, 2. create new \
files (for folders), 3. direct file operations, 4. additional file operations, 5. \
everything else)</p></blockquote>
<p>I would approve of that. It's what macOS does, FWIW:</p>
<p><a href="https://phabricator.kde.org/F5762927" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5762927: finder menu.png</a></p>
<p>As you can see from the above image, macOS doesn't tell you what app will \
launch in response to the <span><span class="phui-tag-view phui-tag-type-shade \
phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open</span></span></span> \
action, so this patch would actually represent a usability improvement over that. \
However, re-ordering the menu would need to be changed in Dolphin, not here in KIO. \
That change (if we do it) should go into 18.08.0, to make sure that it can rely on \
this change (if it's accepted).</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11569">https://phabricator.kde.org/D11569</a></div></div><br \
/><div><strong>To: </strong>ngraham, rkflx, VDG, Frameworks, Dolphin, dfaure, \
elvisangelaccio<br /><strong>Cc: </strong>mmustac, davidedmundson, broulik, dfaure, \
elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic