[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D1231: Add Remote Access interface to KWayland
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-03-22 17:50:29
Message-ID: 20180322175029.1.6C284029FB1DECBB () phabricator ! kde ! org
[Download RAW message or body]

romangg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:430
> +target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui KF5::WaylandClient \
> KF5::WaylandServer) +add_test(kwayland-testRemoteAccess testRemoteAccess)
> +ecm_mark_as_test(testRemoteAccess)

`add_test(NAME kwayland-testRemoteAccess COMMAND testRemoteAccess)`

otherwise ctest doesn't find the test.

> remote_access_interface.cpp:206
> +        // clients don't necessarily bind outputs
> +        if (boundScreens.isEmpty())
> +            return;

Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, \
plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">romangg added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1231">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1231#inline-57313">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:430</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui KF5::WaylandClient \
KF5::WaylandServer) </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">add_test(kwayland-testRemoteAccess testRemoteAccess) \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">add_test(NAME \
kwayland-testRemoteAccess COMMAND testRemoteAccess)</tt></p>

<p style="padding: 0; margin: 8px;">otherwise ctest doesn&#039;t find the \
test.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1231#inline-57288">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">remote_access_interface.cpp:206</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#74777d">// clients don&#39;t necessarily bind outputs</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">boundScreens</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">())</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: \
#aa4000">return</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use \
braces: <a href="https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1231">https://phabricator.kde.org/D1231</a></div></div><br \
/><div><strong>To: </strong>Kanedias, graesslin, davidedmundson, romangg<br \
/><strong>Cc: </strong>jtamate, jgrulich, romangg, ngraham, alexeymin, Frameworks, \
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]