[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D10749: Add ECMSetupQtPluginMacroNames
From:       Friedrich W. H. Kossebau <noreply () phabricator ! kde ! org>
Date:       2018-03-13 19:05:24
Message-ID: 20180313190524.1.B5CD973BE56B055D () phabricator ! kde ! org
[Download RAW message or body]

kossebau added a comment.


  Questions had been:
  A) names of macro and arguments okay?
  B) other/similar/related use cases which should be covered?
  C) how to design argument passing for all the arg1, arg2, arg3? Is the currrent \
approach sane or how to support someone needing some arg5?  
  No answers all the time mapped to: current approach okay :)
  
  For usage & purpose of this macro see D11294 <https://phabricator.kde.org/D11294>, \
D11295 <https://phabricator.kde.org/D11295>, D11296 \
<https://phabricator.kde.org/D11296>  
  Also related:
  
  - intermediate non-ecm-macro-based fixes for KF5 modules by D10733 \
<https://phabricator.kde.org/D10733>, D10732 <https://phabricator.kde.org/D10732>, \
                D10724 <https://phabricator.kde.org/D10724>
  - related CMake issue https://gitlab.kitware.com/cmake/cmake/issues/17750
  
  Would push Monday, March 19th if no-one objects or has some comment.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh


[Attachment #3 (unknown)]

<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10749">View Revision</a></tr></table><br \
/><div><div><p>Questions had been:<br /> A) names of macro and arguments okay?<br />
B) other/similar/related use cases which should be covered?<br />
C) how to design argument passing for all the arg1, arg2, arg3? Is the currrent \
approach sane or how to support someone needing some arg5?</p>

<p>No answers all the time mapped to: current approach okay :)</p>

<p>For usage &amp; purpose of this macro see <a \
href="https://phabricator.kde.org/D11294" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11294</a>, <a \
href="https://phabricator.kde.org/D11295" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11295</a>, <a \
href="https://phabricator.kde.org/D11296" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11296</a></p>

<p>Also related:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">intermediate non-ecm-macro-based fixes for KF5 modules \
by <a href="https://phabricator.kde.org/D10733" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D10733</a>, <a \
href="https://phabricator.kde.org/D10732" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D10732</a>, <a \
href="https://phabricator.kde.org/D10724" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D10724</a></li>
<li class="remarkup-list-item">related CMake issue <a \
href="https://gitlab.kitware.com/cmake/cmake/issues/17750" class="remarkup-link" \
target="_blank" rel="noreferrer">https://gitlab.kitware.com/cmake/cmake/issues/17750</a></li>
 </ul>

<p>Would push Monday, March 19th if no-one objects or has some \
comment.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra \
CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10749">https://phabricator.kde.org/D10749</a></div></div><br \
/><div><strong>To: </strong>kossebau, Build System, Frameworks<br /><strong>Cc: \
</strong>michaelh<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]