[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D8917: Reduce the amount of spurious property changes on ColorScope
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2018-02-12 10:15:56
Message-ID: 20180212101556.1.7EB8D12D6BA530F9 () phabricator ! kde ! org
[Download RAW message or body]

dfaure added inline comments.

INLINE COMMENTS

> colorscope.h:131
> +    QObject *const m_parent;
> +    Plasma::Theme::ColorGroup m_actualGroup;
> 

valgrind says this member isn't initialized, please fix.

http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8917

To: apol, #plasma, mart, davidedmundson
Cc: dfaure, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8917" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8917#inline-49196" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">colorscope.h:131</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">    <span class="n">QObject</span> <span \
style="color: #aa2211">*</span><span class="n">m_parent</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">QObject</span> <span style="color: \
#aa2211">*<span class="bright"></span></span><span class="bright"></span><span \
style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> \
</span><span class="n">m_parent</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">Plasma</span><span style="color: #aa2211">::</span><span \
class="n">Theme</span><span style="color: #aa2211">::</span><span \
class="n">ColorGroup</span> <span class="n">m_actualGroup</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">valgrind says this member isn&#039;t initialized, please fix.</p>

<p style="padding: 0; margin: 8px;"><a \
href="http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt" \
class="remarkup-link" target="_blank" \
rel="noreferrer">http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8917" \
rel="noreferrer">https://phabricator.kde.org/D8917</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma, mart, davidedmundson<br /><strong>Cc: \
</strong>dfaure, davidedmundson, plasma-devel, Frameworks, michaelh, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]