[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D9966: [KIO] Fix issues with sharing of file descriptor
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2018-02-02 23:42:23
Message-ID: 20180202234223.1.81B8F7F571B10B4F () phabricator ! kde ! org
[Download RAW message or body]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thiago, Ossi, looks ok to you too?
  
  (Tagging tomorrow...)

INLINE COMMENTS

> dfaure wrote in sharefd_p.h:51
> Is strlen needed? It seems to me that sun_path will be null if make_address failed, \
> so a simple null-pointer check would be enough here. Plus I remember some \
> implementations of strlen breaking on null pointers...

Looks good.

My own comment was partly nonsense, I see now (sun_path can't be a null pointer). But \
still this change is for the better, it makes it faster.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh


[Attachment #3 (unknown)]

<table><tr><td style="">dfaure accepted this revision.<br />dfaure added a \
comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9966" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thiago, Ossi, looks \
ok to you too?</p>

<p>(Tagging tomorrow...)</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9966#inline-46767" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">sharefd_p.h:51</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Is strlen needed? It seems to me that sun_path will be null if make_address \
failed, so a simple null-pointer check would be enough here. Plus I remember some \
implementations of strlen breaking on null pointers...</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Looks \
good.</p>

<p style="padding: 0; margin: 8px;">My own comment was partly nonsense, I see now \
(sun_path can&#039;t be a null pointer). But still this change is for the better, it \
makes it faster.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9966" \
rel="noreferrer">https://phabricator.kde.org/D9966</a></div></div><br \
/><div><strong>To: </strong>chinmoyr, Frameworks, thiago, dfaure, ossi<br \
/><strong>Cc: </strong>ngraham, fvogt, lbeltrame, dfaure, michaelh<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]