[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D10024: Add supportedSchemes feature
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2018-01-24 8:30:01
Message-ID: 20180124083001.1.442C27D99AD5054A () phabricator ! kde ! org
[Download RAW message or body]

dfaure added inline comments.

INLINE COMMENTS

> kfilewidget.h:498
> +    /**
> +     * Set the URL schemes that the file widget should allow navigating to.
> +     *

All of these public methods should indicate that the default list is *empty* and that \
empty means "all schemes are supported". I don't want to see people thinking they \
have to call this for anything to work, since that would only lead to unnecessarily \
limiting the amount of supported schemes in all cases where there's no reason to \
limit that.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure, mart
Cc: mart, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (unknown)]

<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10024" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10024#inline-46222" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kfilewidget.h:498</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">/**</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #74777d">     * Set the URL schemes that the file widget \
should allow navigating to.</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     *</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">All of these public methods should indicate that the default list is \
*empty* and that empty means &quot;all schemes are supported&quot;.<br /> I \
don&#039;t want to see people thinking they have to call this for anything to work, \
since that would only lead to unnecessarily limiting the amount of supported schemes \
in all cases where there&#039;s no reason to limit \
that.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10024" \
rel="noreferrer">https://phabricator.kde.org/D10024</a></div></div><br \
/><div><strong>To: </strong>mwolff, Plasma, dfaure, mart<br /><strong>Cc: \
</strong>mart, apol, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]