[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D8917: Reduce the amount of spurious property changes on ColorScope
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-12-01 15:32:48
Message-ID: 20171201153248.69887.72CE8C922AFC5F02 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  description needs updating with the new benefits (saving lookups every time)

INLINE COMMENTS

> colorscope.cpp:193
> if (value.window) {
> emit colorGroupChanged();
> }

check here.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8917

To: apol, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8917" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>description needs updating with the new \
benefits (saving lookups every time)</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8917#inline-40895" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">colorscope.cpp:193</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">       \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">value</span><span class="p">.</span><span class="n">window</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; ">            <span class="n">emit</span> <span \
class="n">colorGroupChanged</span><span class="p">();</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">          \
<span class="n">emit</span> <span style="color: #004012">colorsChanged</span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; ">        <span \
class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">check here.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8917" \
rel="noreferrer">https://phabricator.kde.org/D8917</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma, mart, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]