[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D7891: expose the colorset for the stylesheet
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-09-29 14:54:12
Message-ID: 20170929144114.35517.A5FCD095AB9A7669 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> dfaure wrote in kiconloader.h:465
> I guess this is OK as is, so remove the comment (it's not we can change this later)

apparently this is giving problems indeed, polkit is now failing to build since it \
wasn't explicitly linking to KConfigWidgets, so may be necessary to duplicate the \
enum

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D7891

To: mart, #frameworks, #plasma, hein, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7891" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7891#inline-32897" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">kiconloader.h:465</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">I guess this is OK as is, so \
remove the comment (it&#039;s not we can change this later)</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">apparently this is giving problems indeed, polkit is now failing to build since \
it wasn&#039;t explicitly linking to KConfigWidgets, so may be necessary to duplicate \
the enum</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R302 KIconThemes</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7891" \
rel="noreferrer">https://phabricator.kde.org/D7891</a></div></div><br \
/><div><strong>To: </strong>mart, Frameworks, Plasma, hein, dfaure<br /><strong>Cc: \
</strong>plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]