[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D8046: [FrameSvgItem] Iterate child nodes properly
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-09-28 20:47:09
Message-ID: differential-rev-PHID-DREV-hhk5ppudkj7iwdsi5bom-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Documentation says "Children are stored internally as a linked list, so iterating \
over the children via the index is suboptimal."

TEST PLAN
  Verified that it doesn't crash and the number of repositioned nodes stays \
identical, ie. I didn't miss one.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8046

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: \
Plasma.<br />Restricted Application added projects: Plasma, Frameworks.<br \
/>Restricted Application added subscribers: Frameworks, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8046" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Documentation says &quot;Children are stored internally as a \
linked list, so iterating over the children via the index is \
suboptimal.&quot;</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Verified that it doesn&#039;t crash and the number of \
repositioned nodes stays identical, ie. I didn&#039;t miss one.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8046" \
rel="noreferrer">https://phabricator.kde.org/D8046</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/declarativeimports/core/framesvgitem.cpp</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]