[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D7628: Clear previous actions on update
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-08-31 13:09:26
Message-ID: differential-rev-PHID-DREV-fgbt4btbk7n5ym73mbog-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  addAction() doesn't check if an action already exists with that name so
  we have a tiny memory leak.
  
  Also I wanted to try and support actions potentially changing if a
  remote service gets restarted. So we should clear our current actions
  before repopulating

TEST PLAN
  Builds

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7628

AFFECTED FILES
  src/dbusrunner.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added projects: Plasma, Frameworks.<br />Restricted Application added \
subscribers: Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7628" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>addAction() doesn&#039;t check if an action already exists \
with that name so<br /> we have a tiny memory leak.</p>

<p>Also I wanted to try and support actions potentially changing if a<br />
remote service gets restarted. So we should clear our current actions<br />
before repopulating</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Builds</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7628" \
rel="noreferrer">https://phabricator.kde.org/D7628</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/dbusrunner.cpp</div></div></div><br /><div><strong>To: \
</strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]