[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-08-29 12:38:39
Message-ID: differential-rev-PHID-DREV-wdsuiwvjg7almmf5qaxt-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The appendCategory(ConfigCategory*) allows to add a category created by e.g. an \
Instantiator that can use bindings rather than fixed arguments.  The removeCategory \
methods allow to remove a category when e.g. the model in an Instantiator resets.  
  CCBUG: 372090

TEST PLAN
  Pre-requisite for dynamically showing and hiding calendar plugin config in digital \
clock.  
  Verified that onObjectAdded and onObjectRemoved of an Instantiator work fine with \
ConfigModel.  
  Adding an overload shouldn't cause issues as the others require at least four \
string arguments and you cannot pass null as QString from QML anyway.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7602

AFFECTED FILES
  src/plasmaquick/configmodel.cpp
  src/plasmaquick/configmodel.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: \
Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7602" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
appendCategory(ConfigCategory*) allows to add a category created by e.g. an \
Instantiator that can use bindings rather than fixed arguments.<br /> The \
removeCategory methods allow to remove a category when e.g. the model in an \
Instantiator resets.</p>

<p>CCBUG: 372090</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Pre-requisite for dynamically showing and hiding calendar plugin \
config in digital clock.</p>

<p>Verified that onObjectAdded and onObjectRemoved of an Instantiator work fine with \
ConfigModel.</p>

<p>Adding an overload shouldn&#039;t cause issues as the others require at least four \
string arguments and you cannot pass null as QString from QML \
anyway.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma \
Framework (Library)</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D7602" \
rel="noreferrer">https://phabricator.kde.org/D7602</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/plasmaquick/configmodel.cpp<br /> \
src/plasmaquick/configmodel.h</div></div></div><br /><div><strong>To: \
</strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, \
lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]