[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6964: Force Plasma style for QQC2 in applets
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-07-28 14:22:22
Message-ID: differential-rev-PHID-DREV-pl2aoiy5pwet666raytx-req () phabricator ! kde ! org
[Download RAW message or body]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  using the qml url interceptor, rewrite imports in order
  to load always the plasma styled qqc2 controls in plasmoids
  and plasma views. As is per-engine, is possible to load
  controls with qstyle theme in configuration dialogs
  and plasma style in plasmoids.
  
  Note: this replaces just the style org.kde.desktop
  to Plasma and not every style (so with Material
  set as QT_QUICK_CONTROLS_STYLE environment variable
  plasma would load controls with material style) because
  we can control both org.kde.desktop and Plasma styles:
  they must have the same subdirectories as unlike files,
  their existence is checked before the rewrite (in our case,
   "private"), so in order to work they must exist in both
  styles

TEST PLAN
  a qqc2 button in a plasmoid has the plasma style, in
  a config dialog has the qwidget style. rewrite works
  only from org.kde.desktop to Plasma and not from other
  styles, due to the existence of the "private" subdirectory

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6964

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/view.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart created this revision.<br />Restricted Application added \
projects: Plasma, Frameworks.<br />Restricted Application added subscribers: \
Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6964" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>using \
the qml url interceptor, rewrite imports in order<br /> to load always the plasma \
styled qqc2 controls in plasmoids<br /> and plasma views. As is per-engine, is \
possible to load<br /> controls with qstyle theme in configuration dialogs<br />
and plasma style in plasmoids.</p>

<p>Note: this replaces just the style org.kde.desktop<br />
to Plasma and not every style (so with Material<br />
set as QT_QUICK_CONTROLS_STYLE environment variable<br />
plasma would load controls with material style) because<br />
we can control both org.kde.desktop and Plasma styles:<br />
they must have the same subdirectories as unlike files,<br />
their existence is checked before the rewrite (in our case,<br />
 &quot;private&quot;), so in order to work they must exist in both<br />
styles</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>a qqc2 button in a \
plasmoid has the plasma style, in<br /> a config dialog has the qwidget style. \
rewrite works<br /> only from org.kde.desktop to Plasma and not from other<br />
styles, due to the existence of the &quot;private&quot; \
subdirectory</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 \
Plasma Framework (Library)</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6964" \
rel="noreferrer">https://phabricator.kde.org/D6964</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/plasmaquick/appletquickitem.cpp<br /> \
src/plasmaquick/packageurlinterceptor.cpp<br /> \
src/plasmaquick/packageurlinterceptor.h<br /> \
src/plasmaquick/view.cpp</div></div></div><br /><div><strong>To: </strong>mart, \
Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic