[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl
From: Gregor Mi <codestruct () posteo ! org>
Date: 2017-07-27 11:16:31
Message-ID: 20170727111631.30502.79974 () mimi ! kde ! org
[Download RAW message or body]
--===============8738962058534032920==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 20, 2016, 9:52 p.m., David Faure wrote:
> > I forgot to review this, sorry for the delay.
Sorry my own delay. Thanks for the detailled review. Everything should be fixed now.
- Gregor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/#review100988
-----------------------------------------------------------
On July 27, 2017, 11:15 a.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127111/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 11:15 a.m.)
>
>
> Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus.
>
>
> Bugs: 335616
> https://bugs.kde.org/show_bug.cgi?id=335616
>
>
> Repository: kio
>
>
> Description
> -------
>
> Moved logic from https://git.reviewboard.kde.org/r/123253 to here.
>
> Provides a signal to implement bug https://bugs.kde.org/show_bug.cgi?id=335616: \
> "Dolphin: Navigate to parent folder selects child folder".
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 83b7b73b4b92e09076ece2d4618559ddb8089368
> autotests/urlutiltest.cpp PRE-CREATION
> src/filewidgets/kurlnavigator.h ff155c7bbdc8c72f579f730993286a4dccae6338
> src/filewidgets/kurlnavigator.cpp 033046f06dd5bea3f4124669c55803aba3a31789
> src/filewidgets/urlutil_p.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/127111/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregor Mi
>
>
--===============8738962058534032920==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127111/">https://git.reviewboard.kde.org/r/127111/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 20th, 2016, 9:52 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I forgot to review this, sorry for the \
delay.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry \
my own delay. Thanks for the detailled review. Everything should be fixed \
now.</p></pre> <br />
<p>- Gregor</p>
<br />
<p>On July 27th, 2017, 11:15 a.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Emmanuel Pescosta and Frank \
Reininghaus.</div> <div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated July 27, 2017, 11:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335616">335616</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Moved logic from \
https://git.reviewboard.kde.org/r/123253 to here.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Provides a signal to implement bug \
https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder \
selects child folder".</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: \
grey">(83b7b73b4b92e09076ece2d4618559ddb8089368)</span></li>
<li>autotests/urlutiltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/filewidgets/kurlnavigator.h <span style="color: \
grey">(ff155c7bbdc8c72f579f730993286a4dccae6338)</span></li>
<li>src/filewidgets/kurlnavigator.cpp <span style="color: \
grey">(033046f06dd5bea3f4124669c55803aba3a31789)</span></li>
<li>src/filewidgets/urlutil_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127111/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8738962058534032920==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic