[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6727: Destroy all kwayland objects created by registry when it is destroyed
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-07-16 14:29:23
Message-ID: 20170716142923.51902.24B3AC13A795FB6D () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D6727#125900, @davidedmundson wrote:
  
  > We still need https://phabricator.kde.org/D6571, with my proposed change. That's \
a special case where we delete the connection before the QPA.  
  
  It might be that we don't need it. Also KWin destroys the QPA and maybe that's \
sufficient - Breeze has it's own ConnectionThread which is not shared with KWin's.  
  > My added connect means that we get that signal regardless of whether we're in \
Kwin or not.  > 
  > What we wouldn't need is the ownership changes you did for Breeze (and would \
otherwise still need doing in Oxygen/QtCurve )  > 
  >> May I ask for a small unit test for the new functionality?
  > 
  > For you, a *big* unit test.
  
  Just extend the existing ones - that should do and is hopefully small ;-)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6727

To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6727" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6727#125900" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6727#125900</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>We still need <a \
href="https://phabricator.kde.org/D6571" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6571</a>, with my \
proposed change. That&#039;s a special case where we delete the connection before the \
QPA.</p></div> </blockquote>

<p>It might be that we don&#039;t need it. Also KWin destroys the QPA and maybe \
that&#039;s sufficient - Breeze has it&#039;s own ConnectionThread which is not \
shared with KWin&#039;s.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>My \
added connect means that we get that signal regardless of whether we&#039;re in Kwin \
or not.</p>

<p>What we wouldn&#039;t need is the ownership changes you did for Breeze (and would \
otherwise still need doing in Oxygen/QtCurve )</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>May I \
ask for a small unit test for the new functionality?</p></blockquote>

<p>For you, a *big* unit test.</p></blockquote>

<p>Just extend the existing ones - that should do and is hopefully small \
;-)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 \
KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6727" \
rel="noreferrer">https://phabricator.kde.org/D6727</a></div></div><br \
/><div><strong>To: </strong>davidedmundson<br /><strong>Cc: </strong>graesslin, \
plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]