[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6418: [XDGV6] manage every ping sent
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-29 9:22:45
Message-ID: 20170629092245.16353.C8476E286D84E356 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In https://phabricator.kde.org/D6418#120319, @davidedmundson wrote:
  
  > > for how i did the kwin part, it must be who called it with discardTimer (this \
to allow kwin to receive 2 timeouts before deciding to kill the window)  >
  > Ok, I see how it's meant to work but I don't understand why it's done like that.
  >
  > From what I see Kwayland can call "emit q->pingTimeout ; q->discardTimer() "  and \
your kwin code will still wait for 2 timeouts,  
  
  in this case only one as the second timeout will never be emitted?
  what i could do, is chaning the timeout signature in pingTimeout(serial, attempt) \
so on kwayland-server part, it would emit timeout two times, then delte the timer by \
itself  
  >> most of it is in private, just its creation is mostly identical in the \
implementation of ping in the subclasses  > 
  > Yes, and I'm saying that bit could be shared as a method and called from the \
subclasses.  
  +1

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6418

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6418" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6418#120319" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6418#120319</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>for how i did the kwin part, it must be who called it \
with discardTimer (this to allow kwin to receive 2 timeouts before deciding to kill \
the window)</p></blockquote>

<p>Ok, I see how it&#039;s meant to work but I don&#039;t understand why it&#039;s \
done like that.</p>

<p>From what I see Kwayland can call &quot;emit q-&gt;pingTimeout ; \
q-&gt;discardTimer() &quot;  and your kwin code will still wait for 2 \
timeouts,</p></div> </blockquote>

<p>in this case only one as the second timeout will never be emitted?<br />
what i could do, is chaning the timeout signature in pingTimeout(serial, attempt) so \
on kwayland-server part, it would emit timeout two times, then delte the timer by \
itself</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>most of it is in private, just its creation is mostly identical in the \
implementation of ping in the subclasses</p></blockquote>

<p>Yes, and I&#039;m saying that bit could be shared as a method and called from the \
subclasses.</p></blockquote>

<p>+1</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 \
KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6418" \
rel="noreferrer">https://phabricator.kde.org/D6418</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, davidedmundson, graesslin<br /><strong>Cc: \
</strong>plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]